Skip to content

Generalize device declaration in mnist_hogwild and reinforcement_learning - #1423

Open
pgmoka wants to merge 2 commits into
pytorch:mainfrom
pgmoka:generalize-devices
Open

Generalize device declaration in mnist_hogwild and reinforcement_learning#1423
pgmoka wants to merge 2 commits into
pytorch:mainfrom
pgmoka:generalize-devices

Conversation

@pgmoka

@pgmoka pgmoka commented Aug 6, 2026

Copy link
Copy Markdown

Updates device initialization in mnist_hogwild and reinforcement_learning examples to use torch.accelerator.current_accelerator() following the pattern in gat/main.py.

@meta-cla

meta-cla Bot commented Aug 6, 2026

Copy link
Copy Markdown

Hi @pgmoka!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit 6a30762
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-examples-preview/deploys/6a84d9d9bb4b6700085665e7

@meta-cla meta-cla Bot added the cla signed label Aug 17, 2026
@meta-cla

meta-cla Bot commented Aug 17, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Comment on lines +36 to +40
# Set the device to run on
if use_accel:
device = torch.accelerator.current_accelerator()
else:
device = torch.device('cpu')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device = torch.accelerator.current_accelerator() or torch.device('cpu')


def select_action(state):
state = torch.from_numpy(state).float()
state = torch.from_numpy(state).float().to(device)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do .to(dtype=torch.float, device=device)?

Comment thread mnist_hogwild/main.py
Comment on lines +59 to +65
use_accel = not args.no_accel and torch.accelerator.is_available()

# Set the device to run on
if use_accel:
device = torch.accelerator.current_accelerator()
else:
device = torch.device("cpu")
device = torch.device('cpu')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants