-
Notifications
You must be signed in to change notification settings - Fork 536
[CMake] Update extension/ deps executorch -> executorch_core #10698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10698
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 21 New Failures, 1 Cancelled JobAs of commit e1c7bfd with merge base 4945f4e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -197,8 +196,7 @@ filters = [ | |||
".cpp$", | |||
] | |||
deps = [ | |||
"extension_flat_tensor_schema", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this unecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me add it back. Probably shouldn't remove.
Summary
Most likely, we only need executorch_core. We don't need prim ops for these extensions
Test plan
CI
cc @larryliu0820 @jathu