Convert the unit test from java to kotlin #10702
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10702
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit 4b75a79 with merge base 578358b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
reviewed
May 6, 2025
| @@ -34,6 +35,9 @@ android { | |||
| resources.srcDirs += [ 'src/androidTest/resources' ] | |||
| } | |||
| } | |||
| kotlinOptions { | |||
| jvmTarget = '17' | |||
There was a problem hiding this comment.
Right now we have
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}
is 1.8 possible? Otherwise we make everything 17?
There was a problem hiding this comment.
Yes, we should make it to use 1.8 for kotlin compiler as well for the compatibility, will update.
|
@pytorchbot label "topic: not user facing" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change converts the unit test from java to kotlin.
Test plan
./gradlew :executorch_android:testDebugUnitTest