Skip to content

Reduce memory requirement on export_llama tests with no params #11175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gh/jackzhxng/22/base
Choose a base branch
from

Conversation

jackzhxng
Copy link
Contributor

@jackzhxng jackzhxng commented May 28, 2025

Stack from ghstack (oldest at bottom):

For some reason, after the previous PR in the stack, test_export_llama_lib was ooming on gh actions CI and I couldn't really figure out why, since I profiled the running memory on the test both before and after they were the same. This addresses fixes the ci oom, and I've been meaning to do this anyway since if we are loading a transformer without params specified, we likely just want to test some basic functionality, so a 1 layer makes more sense than a 8 layer default. Have made sure code elsewhere is not relying on this 8 layer default atm.

Differential Revision: D75498713

Copy link

pytorch-bot bot commented May 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11175

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 548ef87 with merge base d5c4ba7 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jackzhxng added a commit that referenced this pull request May 28, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2025
jackzhxng added a commit that referenced this pull request May 28, 2025
@jackzhxng
Copy link
Contributor Author

@jackzhxng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label May 28, 2025
…rams"


For some reason, after the previous PR in the stack, test_export_llama_lib was ooming on gh actions CI and I couldn't really figure out why, since I profiled the running memory on the test both before and after they were the same. This addresses fixes the ci oom, and I've been meaning to do this anyway since if we are loading a transformer without params specified, we likely just want to test some basic functionality, so a 1 layer makes more sense than a 8 layer default. Have made sure code elsewhere is not relying on this 8 layer default atm.

Differential Revision: [D75498713](https://our.internmc.facebook.com/intern/diff/D75498713)

[ghstack-poisoned]
jackzhxng added a commit that referenced this pull request May 29, 2025
Pull Request resolved: #11175




@imported-using-ghimport

Differential Revision: [D75498713](https://our.internmc.facebook.com/intern/diff/D75498713/)
ghstack-source-id: 286576048
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75498713

…rams"


For some reason, after the previous PR in the stack, test_export_llama_lib was ooming on gh actions CI and I couldn't really figure out why, since I profiled the running memory on the test both before and after they were the same. This addresses fixes the ci oom, and I've been meaning to do this anyway since if we are loading a transformer without params specified, we likely just want to test some basic functionality, so a 1 layer makes more sense than a 8 layer default. Have made sure code elsewhere is not relying on this 8 layer default atm.

Differential Revision: [D75498713](https://our.internmc.facebook.com/intern/diff/D75498713)

[ghstack-poisoned]
jackzhxng added a commit that referenced this pull request Jun 2, 2025
Pull Request resolved: #11175




@imported-using-ghimport

Differential Revision: [D75498713](https://our.internmc.facebook.com/intern/diff/D75498713/)
ghstack-source-id: 287631950
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75498713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants