[ET-VK] Modifying should_squeeze function in SqueezeUnsqueezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1. #11177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o not squeeze if significant axis are all 1 and trailing axis are all > 1. This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1. Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/) [ghstack-poisoned]
This was referenced May 28, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11177
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8772a44 with merge base f8a3fd8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 28, 2025
facebook-github-bot
added
the
CLA Signed
This was referenced May 28, 2025
trivedivivek
added a commit
that referenced
this pull request
May 28, 2025
…o not squeeze if significant axis are all 1 and trailing axis are all > 1. This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1. Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/) ghstack-source-id: 286577899 Pull Request resolved: #11177
|
This pull request was exported from Phabricator. Differential Revision: D75483587 |
…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1." This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1. Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75483587 |
…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1." This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1. Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75483587 |
…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1." This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1. Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/) [ghstack-poisoned]
This was referenced May 30, 2025
|
This pull request was exported from Phabricator. Differential Revision: D75483587 |
trivedivivek
added
the
release notes: vulkan
…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1." This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1. Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75483587 |
SS-JIA
approved these changes
May 30, 2025
facebook-github-bot
merged commit 0ac4435
into
gh/trivedivivek/101/base
97 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
May 31, 2025
…o not squeeze if significant axis are all 1 and trailing axis are all > 1. (#11269) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11177 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff modifies the
should_squeezefunction inSqueezeUnsqueezeInputsto not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.Differential Revision: D75483587