Skip to content

[ET-VK] Modifying should_squeeze function in SqueezeUnsqueezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1. #11177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented May 28, 2025

…o not squeeze if significant axis are all 1 and trailing axis are all > 1.

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11177

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8772a44 with merge base f8a3fd8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2025
trivedivivek added a commit that referenced this pull request May 28, 2025
…o not squeeze if significant axis are all 1 and trailing axis are all > 1.

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

ghstack-source-id: 286577899
Pull Request resolved: #11177
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75483587

…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1."

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75483587

…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1."

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75483587

…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1."

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75483587

@trivedivivek trivedivivek added the release notes: vulkan Changes to the Vulkan backend delegate label May 30, 2025
…ezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1."

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75483587

@facebook-github-bot facebook-github-bot merged commit 0ac4435 into gh/trivedivivek/101/base May 30, 2025
97 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/trivedivivek/101/head branch May 30, 2025 20:14
trivedivivek added a commit that referenced this pull request May 31, 2025
…o not squeeze if significant axis are all 1 and trailing axis are all > 1. (#11269)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11177 by
@trivedivivek
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/orig
@diff-train-skip-merge

Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants