-
Notifications
You must be signed in to change notification settings - Fork 574
Fix output spec + insert clone for constant_prop_pass. #11209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11209
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c8edf18 with merge base 1bc36c7 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
1320e5b
to
ef607f4
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: Pull Request resolved: pytorch#11209 In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
ef607f4
to
4fed1e9
Compare
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
4fed1e9
to
eb356d9
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: Pull Request resolved: pytorch#11209 In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
eb356d9
to
177306c
Compare
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
177306c
to
2cdd1c6
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
2cdd1c6
to
c52631c
Compare
Summary: Pull Request resolved: pytorch#11209 In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
c52631c
to
4a9039e
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
4a9039e
to
ea795a8
Compare
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
ea795a8
to
78c294f
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: Pull Request resolved: pytorch#11209 In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
78c294f
to
4dd05b8
Compare
4dd05b8
to
1cf74c5
Compare
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Differential Revision: D75473310
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Reviewed By: angelayi Differential Revision: D75473310
1cf74c5
to
2650b17
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Reviewed By: angelayi Differential Revision: D75473310
2650b17
to
39e70dd
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary: Pull Request resolved: pytorch#11209 In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Reviewed By: angelayi Differential Revision: D75473310
39e70dd
to
00534c8
Compare
Summary: In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature: ``` User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list. ``` This diff does two things: 1. Update output spec when propagated constants are output of the program. 2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors. Reviewed By: angelayi Differential Revision: D75473310
00534c8
to
c8edf18
Compare
This pull request was exported from Phabricator. Differential Revision: D75473310 |
Summary:
In case where a constant propagated node is returned by the exported program,
_validate()
fails withSpecViolationError
with signature:This diff does two things:
Differential Revision: D75473310