Skip to content

Fix output spec + insert clone for constant_prop_pass. #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hsharma35
Copy link
Contributor

Summary:
In case where a constant propagated node is returned by the exported program, _validate() fails with SpecViolationError with signature:

User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.

This diff does two things:

  1. Update output spec when propagated constants are output of the program.
  2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310

Copy link

pytorch-bot bot commented May 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11209

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c8edf18 with merge base 1bc36c7 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 29, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 29, 2025
Summary:
Pull Request resolved: pytorch#11209

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 29, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 29, 2025
Summary:
Pull Request resolved: pytorch#11209

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@hsharma35 hsharma35 added the release notes: none Do not include this in the release notes label May 29, 2025
hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 29, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 29, 2025
Summary:
Pull Request resolved: pytorch#11209

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 30, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 30, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 30, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request May 30, 2025
Summary:
Pull Request resolved: pytorch#11209

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@hsharma35 hsharma35 requested review from kimishpatel and removed request for tarun292 May 31, 2025 01:36
hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 2, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Differential Revision: D75473310
@hsharma35 hsharma35 requested a review from angelayi June 2, 2025 17:02
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 2, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Reviewed By: angelayi

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 2, 2025
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Reviewed By: angelayi

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 2, 2025
Summary:
Pull Request resolved: pytorch#11209

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Reviewed By: angelayi

Differential Revision: D75473310
Summary:

In case where a constant propagated node is returned by the exported program, `_validate()` fails with `SpecViolationError` with signature:
```
User output <SOME_CONSTANT_PROP_NODE> is not in the correct order or is not found in the exported program's user_output list.
```
This diff does two things:
1. Update output spec when propagated constants are output of the program.
2. Insert clone op on the constant prop tensor before sending them to output node. This avoid memory planning related errors.

Reviewed By: angelayi

Differential Revision: D75473310
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75473310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants