Skip to content

[ET-VK] Removed shared memory usage and simplied conv2d dw op shader to improve performance. #11270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11178 by @trivedivivek
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/orig
@diff-train-skip-merge

…o not squeeze if significant axis are all 1 and trailing axis are all > 1.

Pull Request resolved: #11177

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.
ghstack-source-id: 287222796
@exported-using-ghexport

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)
…to improve performance.

Pull Request resolved: #11178

This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance.
Makes sum a one dimensional array, and moves bias application before storing texel.
ghstack-source-id: 287222799
@exported-using-ghexport

Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/)
@pytorchbot pytorchbot requested a review from SS-JIA as a code owner May 30, 2025 20:15
Copy link

pytorch-bot bot commented May 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11270

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7099bcd with merge base f8a3fd8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2025
@trivedivivek trivedivivek added the release notes: vulkan Changes to the Vulkan backend delegate label May 30, 2025
Base automatically changed from gh/trivedivivek/101/orig to main May 31, 2025 01:13
@trivedivivek trivedivivek merged commit 3dcf9b7 into main May 31, 2025
94 of 95 checks passed
@trivedivivek trivedivivek deleted the gh/trivedivivek/102/orig branch May 31, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants