Arm backend: Update VGF test for fused ReLU qparams - #22088
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22088
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6e73ffe with merge base 9a2d135 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
zingo
left a comment
There was a problem hiding this comment.
nit: The updated fused-ReLU coverage looks correct. As a follow-up, would it
make sense to retain a separate non-fusible Conv-Clamp case? The original
test protected that path for #18778, and this change repurposes its only
regression coverage.
Update the VGF rewrite-convolution regression for the ReLU fusion behavior introduced by D116922192.
The ReLU is fused into the convolution before ConvertToClampPass runs, so the clamp is fused away and no clamp node remains. Verify that the fused convolution owns the output quantization parameters with qmin rewritten to the zero point.
Rename the adjacent lowering test to describe the fused Conv-ReLU-Cat path.
Test plan:
buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:rewrite_conv_pass -- --exact "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_fold_and_annotate_q_params_vgf_quant_tracks_fused_relu_qparams"buck test @fbcode//mode/dev fbcode//executorch/backends/arm/test:rewrite_conv_pass -- --exact "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_rewrite_conv_vgf_quant_handles_fused_conv_relu_cat_branch" "fbcode//executorch/backends/arm/test:rewrite_conv_pass - test_rewrite_conv_pass.py::test_rewrite_conv_vgf_quant_infers_quantized_bias_dtype_from_inputs"arc lint -aandarc linton changed filespython -m py_compile backends/arm/test/passes/test_rewrite_conv_pass.pyThis PR was authored with Codex.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani