[executorch][native] Add Argument tagged union to the in-memory IR - #22101
Open
SS-JIA wants to merge 1 commit into
Open
[executorch][native] Add Argument tagged union to the in-memory IR#22101SS-JIA wants to merge 1 commit into
SS-JIA wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22101
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 71e74aa with merge base 9a2d135 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 24, 2026
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds
ptn::Argument, the in-memory form of an fx node argument, mirroring theschema
ArgumentValueunion but with in-graph references resolved toValueRefarena indices instead of SSA-name strings (the deserializer will do the name ->
ref resolution).
Argumentis a hand-rolled real tagged union: anArgKindtag over a Cunionof the 13 payload structs (
TensorArg,IntArg,TensorListArg,GraphArg,...). This matches the value layer's existing style (
Scalar,Value) andkeeps storage compact (size = largest payload + tag) rather than pulling in
std::variant. Because several payloads are non-trivial (std::string,std::vector), lifetime is managed by hand viadestroy()/construct_from(const&)/construct_from(&&); copy-assign builds a temporarythen steals it through the
noexceptmove-assign for a strong exceptionguarantee. Payloads are read via
kind()+ throwingas_*()accessors, thesame idiom as
Value.Symbolic scalar args carry both a literal
valueand aref(validref=>symbolic, e.g. a
sym_sizeresult).OptionalTensorListArgcollapses theschema's parallel
has_value[]into akInvalidsentinel per element.GraphArgholds aGraphRef(index into a subgraph arena that lands withGraph/Model), not an owned subgraph, soArgumentneeds noGraphdependency, forward declaration, or incomplete-type destructor.
NamedArgumentwraps an
Argumentwith its op-schema parameter name and an in-placemutatedflag.
Also adds
using GraphRef = int32_t;toIds.hfor theGraphArghandle.Pure std only (no ExecuTorch, no flatbuffers), consistent with the rest of the
standalone
ptnruntime.Differential Revision: D114396764