Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CMake EXECUTORCH_BUILD_KERNELS_CUSTOM to EXECUTORCH_BUILD_EXTENSION_LLM #5743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 29, 2024

Rename EXECUTORCH_BUILD_KERNELS_CUSTOM to EXECUTORCH_BUILD_EXTENSION_LLM. This improves clarity for users and prevents us from needing to keep EXECUTORCH_BUILD_KERNELS_CUSTOM post-API stability guarantees.

Note that the two CI failures are due to running CI from a fork.

Copy link

pytorch-bot bot commented Sep 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5743

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit 22d6aeb with merge base 905b88c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2024
@GregoryComer GregoryComer added ciflow/periodic ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 29, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2024
@GregoryComer GregoryComer force-pushed the rename-llm-kernel-cmake branch from a8c8f8e to 57d2f52 Compare September 29, 2024 12:22
@GregoryComer GregoryComer force-pushed the rename-llm-kernel-cmake branch from 57d2f52 to 22d6aeb Compare September 30, 2024 02:09
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer marked this pull request as ready for review September 30, 2024 04:39
Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm makes sense, looking at
DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON
and
DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON

seems hard to tell the difference between what is 'optimized' and what is 'custom'

@@ -168,7 +168,7 @@ cmake_build() {
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=$CUSTOM \
-DEXECUTORCH_BUILD_EXTENSION_LLM=$CUSTOM \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we continue to apply this renaming to the rest of the kernels custom instances, does that mean we're gonna distribute extension llm package eventually on apple platforms together with the executorch runtime?
Please check out what it looks like now for the end users https://pytorch.org/executorch/main/apple-runtime.html
I guess kernels customer are in fact some kernels for llms?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoumikhin Yeah, that makes sense to me. If we rename them to llm kernels, do I just need to update the frameworks build as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants