-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CMake EXECUTORCH_BUILD_KERNELS_CUSTOM to EXECUTORCH_BUILD_EXTENSION_LLM #5743
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5743
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit 22d6aeb with merge base 905b88c ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
a8c8f8e
to
57d2f52
Compare
57d2f52
to
22d6aeb
Compare
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm makes sense, looking at
DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON
and
DEXECUTORCH_BUILD_KERNELS_CUSTOM=ON
seems hard to tell the difference between what is 'optimized' and what is 'custom'
@@ -168,7 +168,7 @@ cmake_build() { | |||
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \ | |||
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \ | |||
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \ | |||
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=$CUSTOM \ | |||
-DEXECUTORCH_BUILD_EXTENSION_LLM=$CUSTOM \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we continue to apply this renaming to the rest of the kernels custom instances, does that mean we're gonna distribute extension llm package eventually on apple platforms together with the executorch runtime?
Please check out what it looks like now for the end users https://pytorch.org/executorch/main/apple-runtime.html
I guess kernels customer are in fact some kernels for llms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shoumikhin Yeah, that makes sense to me. If we rename them to llm kernels, do I just need to update the frameworks build as well?
Rename EXECUTORCH_BUILD_KERNELS_CUSTOM to EXECUTORCH_BUILD_EXTENSION_LLM. This improves clarity for users and prevents us from needing to keep EXECUTORCH_BUILD_KERNELS_CUSTOM post-API stability guarantees.
Note that the two CI failures are due to running CI from a fork.