Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xnnpack] Improve qd8-f16 testing #7745

Open
wants to merge 1 commit into
base: gh/digantdesai/3/base
Choose a base branch
from

Conversation

digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Jan 17, 2025

Stack from ghstack (oldest at bottom):

Differential Revision: D68350952

* Added a few qd8 fp16 tests for qc4w and qc8w
* Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues
* Created a TODO to look into atol values

Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7745

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit f5f888b with merge base fbb0395 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
digantdesai added a commit that referenced this pull request Jan 17, 2025
* Added a few qd8 fp16 tests for qc4w and qc8w
* Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues
* Created a TODO to look into atol values

Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/)

ghstack-source-id: 261969300
Pull Request resolved: #7745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68350952

@digantdesai digantdesai added the release notes: xnnpack Changes to the XNNPack backend delegate label Jan 17, 2025
@digantdesai digantdesai requested a review from mcr229 January 17, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: xnnpack Changes to the XNNPack backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants