[xnnpack] Improve qd8-f16 testing #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7745
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7fc43a8 with merge base f58c8ec ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
added a commit
that referenced
this pull request
Jan 17, 2025
* Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) ghstack-source-id: 261969300 Pull Request resolved: #7745
|
This pull request was exported from Phabricator. Differential Revision: D68350952 |
digantdesai
added
the
release notes: xnnpack
mcr229
approved these changes
Jan 22, 2025
* Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68350952 |
digantdesai
added a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7745 * Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values ghstack-source-id: 262422438 @exported-using-ghexport Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/)
* Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) [ghstack-poisoned]
digantdesai
added a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7745 * Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values ghstack-source-id: 262438488 @exported-using-ghexport Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/)
|
This pull request was exported from Phabricator. Differential Revision: D68350952 |
facebook-github-bot
merged commit 8b5e807
into
gh/digantdesai/3/base
45 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7745 * Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values ghstack-source-id: 262438488 @exported-using-ghexport Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/)
kirklandsign
pushed a commit
that referenced
this pull request
Jan 22, 2025
Pull Request resolved: #7745 * Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values ghstack-source-id: 262438488 @exported-using-ghexport Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) Co-authored-by: Digant Desai <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Pull Request resolved: #7745 * Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values ghstack-source-id: 262438488 @exported-using-ghexport Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) Co-authored-by: Digant Desai <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Pull Request resolved: pytorch#7745 * Added a few qd8 fp16 tests for qc4w and qc8w * Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues * Created a TODO to look into atol values ghstack-source-id: 262438488 @exported-using-ghexport Differential Revision: [D68350952](https://our.internmc.facebook.com/intern/diff/D68350952/) Co-authored-by: Digant Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
-> [xnnpack] Improve qd8-f16 testing #7745
[xnnpack] Refactor test/op_linear #7744
Added a few qd8 fp16 tests for qc4w and qc8w
Cleaned up and split fp16 and fp32 for basic tests to avoid getting confused regarding atol issues
Created a TODO to look into atol values
Differential Revision: D68350952