Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't default to -fno-exceptions -fno-rtti #7746

Open
wants to merge 1 commit into
base: gh/swolchok/142/head
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

We need exceptions/RTTI for non-core-only use cases (see #7736).
Sending first version of this without patching any specific targets to restore these flags because I want to see if anything actually breaks.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 17, 2025

Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7746

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit d47c434 with merge base cd0e584 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
swolchok added a commit that referenced this pull request Jan 17, 2025
We need exceptions/RTTI for non-core-only use cases (see #7736).
Sending first version of this without patching any specific targets to restore these flags because I want to see if anything actually breaks.

ghstack-source-id: c8fbe3a65fdf3dd15d227f96ff4b0c26521eaea6
ghstack-comment-id: 2599307626
Pull Request resolved: #7746
@swolchok
Copy link
Contributor Author

phi-3-mini and emformer-transcribe failures are from trunk, so it looks likely that this doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants