Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Half/BFloat16 in native_layer_norm #7752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Half/BFloat16 in native_layer_norm #7752

wants to merge 1 commit into from
+18 −7

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 17, 2025 •
edited
Loading

Partial fix for #7748 .

@swolchok
Update
30ab065 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 17, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7752

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 30ab065 with merge base 57a09f4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
Support Half/BFloat16 in native_layer_norm
bff3ad3 
ghstack-source-id: f8d98dddce9c5fc56d75eb3bb48f228686a4dc76
ghstack-comment-id: 2599385748
Pull Request resolved: #7752
@swolchok swolchok requested review from manuelcandales, lucylq and GregoryComer and removed request for manuelcandales, lucylq and GregoryComer January 17, 2025 23:53
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

@lucylq lucylq Awaiting requested review from lucylq

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swolchok @facebook-github-bot