Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Half/BFloat16 in topk #7755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Half/BFloat16 in topk #7755

wants to merge 1 commit into from
+32 −24

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 18, 2025 •
edited
Loading

Partial fix for #7748.

@swolchok
Update
be42013 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7755

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit be42013 with merge base 57a09f4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
swolchok added a commit that referenced this pull request Jan 18, 2025
@swolchok
Support Half/BFloat16 in topk
c6be193 
ghstack-source-id: 62412fb8472652c989f28eb2a18ecb2dee0a597b
ghstack-comment-id: 2599393791
Pull Request resolved: #7755
@swolchok swolchok requested review from manuelcandales and kirklandsign and removed request for manuelcandales January 18, 2025 00:05
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swolchok @facebook-github-bot