Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Half/BFloat16 in abs/neg #7760

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Support Half/BFloat16 in abs/neg #7760

merged 2 commits into from
Jan 22, 2025

Conversation

swolchok
Copy link
Contributor

Partial fix for #7748.

@swolchok
Update
5097c8b 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7760

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4412b00 with merge base 57a09f4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
swolchok added a commit that referenced this pull request Jan 18, 2025
@swolchok
Support Half/BFloat16 in abs/neg
ceacbee 
Partial fix for #7748.

ghstack-source-id: a72e5e33f005abc47cc1143f7b282f8050374955
ghstack-comment-id: 2599413770
Pull Request resolved: #7760
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 18, 2025
@swolchok
Update
4412b00 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 18, 2025
@swolchok
Support Half/BFloat16 in abs/neg
98e83e0 
Partial fix for #7748.

ghstack-source-id: 02bfc58615997b27f0ecb99f8efcf7fce0694b8c
ghstack-comment-id: 2599413770
Pull Request resolved: #7760
@swolchok swolchok merged commit cbc8801 into main Jan 22, 2025
44 of 45 checks passed
@swolchok swolchok deleted the gh/swolchok/148/head branch January 22, 2025 17:48
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in abs/neg (#7760)
ad9e38d 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in abs/neg (pytorch#7760)
6da3c87 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @manuelcandales @facebook-github-bot