Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Half/BFloat16 in amax/amin #7767

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Support Half/BFloat16 in amax/amin #7767

merged 1 commit into from
Jan 22, 2025

Conversation

swolchok
Copy link
Contributor

Partial fix for #7748.

@swolchok
Update
5dc9564 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7767

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 5dc9564 with merge base 9836b39 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
swolchok added a commit that referenced this pull request Jan 18, 2025
@swolchok
Support Half/BFloat16 in amax/amin
fbf28cd 
Partial fix for #7748.

ghstack-source-id: b7b33809ec99537c0f44c7abb5880c6502d30698
ghstack-comment-id: 2599481711
Pull Request resolved: #7767
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 21, 2025
@swolchok swolchok merged commit 4bf83b9 into main Jan 22, 2025
43 of 47 checks passed
@swolchok swolchok deleted the gh/swolchok/150/head branch January 22, 2025 17:43
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in amax/amin (#7767)
0c2864a 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in amax/amin (pytorch#7767)
1876344 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @manuelcandales @facebook-github-bot