Support (un)squeeze in XNNPACK delegate via conversion to view #7961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7961
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d9c50c9 with merge base e78ed83 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
added
release notes: xnnpack
facebook-github-bot
added
the
CLA Signed
GregoryComer
force-pushed
the
xnn-squeeze
branch
from
bbc17ca to
d9c50c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new pass to the XNNPACK delegate to convert squeeze and unsqueeze nodes into views. These are then lowered to XNN static_reshape ops.
Note that this PR includes #7959, as it relies on lowering via view.
Test plan
Added test coverage at the pass and operator level under
backends/xnnpack/test/ops/test_squeeze.py,backends/xnnpack/test/ops/test_unsqueeze.py, andbackends/xnnpack/test/passes/test_convert_squeeze_to_view_pass.py.