Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm backend: Add ComputeConstantOpsAOT pass #9504

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Mar 21, 2025

Arm backend: Add ComputeConstantOpsAOT pass
Operators that output tensors based on constant args
are pre-computed and added as buffers.
- The pass currently supports full, arange, linspace, and eye.
- Remove some logic for full now handled by the pass
- Rename FuseConstantOpsPass to FuseConstantArgsPass and do minor improvements

Signed-off-by: Erik Lundell <[email protected]>

Fix retracing in FuseViewCopyTransform
Since the pass can change shapes of ops,
the graph needs to be retraced to show this in node.meta["val"].

Signed-off-by: Erik Lundell <[email protected]>

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Since the pass can change shapes of ops,
the graph needs to be retraced to show this in node.meta["val"].

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ief24fe9d11384a2d0f64f0d91070eca7b0caf18e
Operators that output tensors based on constant args
are pre-computed and added as buffers.
- The pass currently supports full, arange, linspace, and eye.
- Remove some logic for full now handled by the pass
- Rename FuseConstantOpsPass to FuseConstantArgsPass and do minor improvements

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I744e2583a9ed011e350cfaa43410902bd9e54292
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9504

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit bc2162b with merge base 043c7a0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing ciflow/trunk labels Mar 21, 2025
@zingo
Copy link
Collaborator

zingo commented Mar 21, 2025

@digantdesai this PR touched file outside Arm folder. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants