Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimized ELU implementation #9521

Open
wants to merge 3 commits into
base: gh/swolchok/394/head
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 22, 2025

Straightforward application of PyTorch code sharing.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 22, 2025

Copy link

pytorch-bot bot commented Mar 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9521

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 69bfb74 with merge base f13aeff (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 22, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: e75efc93b9a6f7fdd75300f69382bd2d8c2ba943
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2025
@swolchok swolchok marked this pull request as draft March 22, 2025 00:30
@swolchok
Copy link
Contributor Author

swolchok commented Mar 22, 2025

converting to draft because this won't work until we bump the PyTorch pin (I think)

@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Mar 22, 2025
[ghstack-poisoned]
@swolchok swolchok changed the base branch from gh/swolchok/390/head to gh/swolchok/394/head March 25, 2025 15:57
swolchok added a commit that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 22c97348d57b77983c2b2bad6afa6a7454b59097
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
swolchok added a commit that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: 22c97348d57b77983c2b2bad6afa6a7454b59097
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
@swolchok swolchok marked this pull request as ready for review March 25, 2025 16:16
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 25, 2025
This uses PyTorch code sharing, so we'll need a pin bump to pick up
pytorch/pytorch#149673 (and
pytorch/pytorch#149684 and, when it lands,
pytorch/pytorch#149780).

ghstack-source-id: bc31e5db48089db7c8e2871b18839b4882429ab3
ghstack-comment-id: 2744722101
Pull Request resolved: #9521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants