Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test_mimi to ci #9530

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Add test_mimi to ci #9530

merged 1 commit into from
Mar 24, 2025

Conversation

iseeyuan
Copy link
Contributor

Summary

Add test_mimi to ci

Test plan

ci

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9530

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 6a8e772 with merge base 043c7a0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2025
@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@iseeyuan
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

jackzhxng
jackzhxng reviewed Mar 23, 2025
View reviewed changes
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though Llava is already in pull, I would prefer not having these large tests in pull, trunk would be better.

.github/workflows/pull.yml Outdated
@@ -290,6 +290,33 @@ jobs:
# run e2e (export, tokenizer and runner)
PYTHON_EXECUTABLE=python bash .ci/scripts/test_llava.sh

test-moshi-linux:
name: test-llava-runner-linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still says Llava

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@facebook-github-bot
Copy link
Contributor

@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
818874b 
Summary:
Add test_mimi to ci


Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

iseeyuan pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
0fb7c02 
Summary:
Add test_mimi to ci

Pull Request resolved: #9530

Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

iseeyuan pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
72a7685 
Summary:
Add test_mimi to ci

Pull Request resolved: #9530

Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
iseeyuan pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
0008b93 
Summary:
Add test_mimi to ci

Pull Request resolved: #9530

Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
e4590a6 
Summary:
Add test_mimi to ci


Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

facebook-github-bot pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
95648e3 
Summary:
Add test_mimi to ci


Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

iseeyuan pushed a commit that referenced this pull request Mar 24, 2025
@facebook-github-bot
Add test_mimi to ci (#9530)
2ee656f 
Summary:
Add test_mimi to ci

Pull Request resolved: #9530

Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Add test_mimi to ci (#9530)
6a8e772 
Summary:
Add test_mimi to ci

Pull Request resolved: #9530

Test Plan: ci

Reviewed By: billmguo

Differential Revision: D71699919

Pulled By: iseeyuan
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71699919

@facebook-github-bot facebook-github-bot merged commit 7063c26 into main Mar 24, 2025
81 of 83 checks passed
@facebook-github-bot facebook-github-bot deleted the mimici branch March 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzhxng jackzhxng jackzhxng left review comments

@billmguo billmguo billmguo approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iseeyuan @facebook-github-bot @billmguo @jackzhxng