Skip to content

Commit

Permalink
Correct the condition when setting External id (#978)
Browse files Browse the repository at this point in the history
Summary:
The `External id` will be set to op.linkedActivity()->correlationId() if op.linkedActivity() is not nullptr. So in `if` condition we should check if op.linkedActivity()->correlationId() is 0.

Pull Request resolved: #978

Reviewed By: xuzhao9

Differential Revision: D61608345

Pulled By: aaronenyeshi

fbshipit-source-id: edc2c121a970756f008cae10a175b1f7066af18c
  • Loading branch information
fuwenguang authored and facebook-github-bot committed Aug 22, 2024
1 parent ba989ce commit ba4caf6
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions libkineto/src/output_json.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,10 @@ void ChromeTraceLogger::handleActivity(
}

std::string arg_values = "";
if (op.correlationId() != 0) {
arg_values.append(fmt::format("\"External id\": {}",
op.linkedActivity() ? op.linkedActivity()->correlationId() : op.correlationId()));
if (op.linkedActivity() && op.linkedActivity()->correlationId() != 0) {
arg_values.append(fmt::format("\"External id\": {}", op.linkedActivity()->correlationId()));
} else if (op.correlationId() != 0) {
arg_values.append(fmt::format("\"External id\": {}", op.correlationId()));
}
std::string op_metadata = op.metadataJson();
sanitizeStrForJSON(op_metadata);
Expand Down

0 comments on commit ba4caf6

Please sign in to comment.