Fix Windows builds due to missing helper func #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes an issue causing windows builds to fail pytorch#1035 Reviewed By: xunnanxu Differential Revision: D69608709
|
This pull request was exported from Phabricator. Differential Revision: D69608709 |
|
This pull request has been merged in a054a4b. |
This was referenced Feb 14, 2025
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 15, 2025
Fixes an issue causing windows builds to fail pytorch/kineto#1039 Pull Request resolved: #147195 Approved by: https://github.com/cyyever, https://github.com/davidberard98, https://github.com/sraikund16
Tytskiy
pushed a commit
to Tytskiy/pytorch
that referenced
this pull request
Feb 18, 2025
) Fixes an issue causing windows builds to fail pytorch/kineto#1039 Pull Request resolved: pytorch#147195 Approved by: https://github.com/cyyever, https://github.com/davidberard98, https://github.com/sraikund16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an issue causing windows builds to fail
#1035
Reviewed By: xunnanxu
Differential Revision: D69608709