Skip to content

Fix default cupti time converter #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix default cupti time converter #1064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion libkineto/src/CuptiActivityProfiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,18 @@ std::unordered_map<uint32_t, uint32_t>& ctxToDeviceId() {

namespace KINETO_NAMESPACE {

static double cuptiTimeScalingIndex = 1;
static uint64_t systemTimeAncor=0;
static uint64_t cuptiTimeAncor=0;

// Sets the timestamp converter. If nothing is set then the converter just
// returns the input. For this reason, until we add profiler impl of passing in
// TSC converter we just need to guard the callback itself
std::function<time_t(approx_time_t)>& get_time_converter() {
static std::function<time_t(approx_time_t)> _time_converter =
[](approx_time_t t) { return t; };
[](approx_time_t t) {
return systemTimeAncor + uint64_t(double(t - cuptiTimeAncor) / cuptiTimeScalingIndex);
};
return _time_converter;
}
#ifdef HAS_ROCTRACER
Expand Down Expand Up @@ -1223,6 +1229,10 @@ void CuptiActivityProfiler::toggleCollectionDynamic(const bool enable) {
void CuptiActivityProfiler::startTraceInternal(
const time_point<system_clock>& now) {
captureWindowStartTime_ = libkineto::timeSinceEpoch(now);

cuptiGetTimestamp(&cuptiTimeAncor);
systemTimeAncor = libkineto::timeSinceEpoch(now);

VLOG(0) << "Warmup -> CollectTrace";
for (auto& session : sessions_) {
LOG(INFO) << "Starting child profiler session";
Expand All @@ -1234,6 +1244,12 @@ void CuptiActivityProfiler::startTraceInternal(
void CuptiActivityProfiler::stopTraceInternal(
const time_point<system_clock>& now) {
captureWindowEndTime_ = libkineto::timeSinceEpoch(now);

uint64_t cuptiTimestamp;
cuptiGetTimestamp(&cuptiTimestamp);

cuptiTimeScalingIndex = double(cuptiTimestamp - cuptiTimeAncor) / double(captureWindowEndTime_ - systemTimeAncor);

#if defined(HAS_CUPTI) || defined(HAS_ROCTRACER)
if (!cpuOnly_) {
time_point<system_clock> timestamp;
Expand Down
Loading