Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libkineto/include/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ class Config : public AbstractConfig {
return customConfig_;
}

uint32_t maxEvents() const {
uint64_t maxEvents() const {
return maxEvents_;
}

Expand Down Expand Up @@ -533,7 +533,7 @@ class Config : public AbstractConfig {
std::string customConfig_;

// Roctracer settings
uint32_t maxEvents_{5000000};
uint64_t maxEvents_{5000000};
};

constexpr char kUseDaemonEnvVar[] = "KINETO_USE_DAEMON";
Expand Down
2 changes: 1 addition & 1 deletion libkineto/src/Config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ bool Config::handleOption(const std::string& name, std::string& val) {
} else if (!name.compare(kRequestGroupTraceID)) {
requestGroupTraceID_ = val;
} else if (!name.compare(kRoctracerSetMaxEvents)) {
maxEvents_ = toInt32(val);
maxEvents_ = toInt64(val);
}

// TODO: Deprecate Client Interface
Expand Down
2 changes: 1 addition & 1 deletion libkineto/src/RoctracerActivityApi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ void RoctracerActivityApi::clearActivities() {
d->clearLogs();
}

void RoctracerActivityApi::setMaxEvents(uint32_t maxEvents) {
void RoctracerActivityApi::setMaxEvents(uint64_t maxEvents) {
#ifdef HAS_ROCTRACER
d->setMaxEvents(maxEvents);
#endif
Expand Down
2 changes: 1 addition & 1 deletion libkineto/src/RoctracerActivityApi.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class RoctracerActivityApi {
void clearActivities();
void flushActivities();
void teardownContext() {}
void setMaxEvents(uint32_t maxEvents);
void setMaxEvents(uint64_t maxEvents);

virtual int processActivities(
std::function<void(const roctracerBase*)> handler,
Expand Down
2 changes: 1 addition & 1 deletion libkineto/src/RoctracerLogger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ void RoctracerLogger::activity_callback(
}
}

void RoctracerLogger::setMaxEvents(uint32_t maxBufferSize) {
void RoctracerLogger::setMaxEvents(uint64_t maxBufferSize) {
#ifdef HAS_ROCTRACER
RoctracerLogger* dis = &singleton();
std::lock_guard<std::mutex> lock(dis->rowsMutex_);
Expand Down
4 changes: 2 additions & 2 deletions libkineto/src/RoctracerLogger.h
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ class RoctracerLogger {
void startLogging();
void stopLogging();
void clearLogs();
void setMaxEvents(uint32_t maxBufferSize);
void setMaxEvents(uint64_t maxBufferSize);

private:
bool registered_{false};
Expand All @@ -285,7 +285,7 @@ class RoctracerLogger {
ApiIdList loggedIds_;

// Api callback data
uint32_t maxBufferSize_{5000000}; // 5M GPU runtime/kernel events.
uint64_t maxBufferSize_{5000000}; // 5M GPU runtime/kernel events.
std::vector<roctracerBase*> rows_;
std::mutex rowsMutex_;

Expand Down