-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XPU profiler] Introduce XPU profiler by following kineto plugin design #961
Conversation
Hi @zejun-chen! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
8ab972d
to
386f0ed
Compare
@aaronenyeshi could you help review? The associated PR in pytorch is pytorch/pytorch#130811 Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check and fix broken CI signals
@zejun-chen pls. follow and fix. Thanks. |
386f0ed
to
561c1d8
Compare
Hi, @aaronenyeshi Thank you for review 👍. Fix the CI error and wait for new CI result. Thank you. |
561c1d8
to
4fe8c30
Compare
Hi, @aaronenyeshi The new CI failure is caused by the missing file cupti.h. Could you help take a look at the CI env?
Thank you |
7ce7bd0
to
0f96de9
Compare
As XPU became a PyTorch built-in device, the profiler support is indispensable part of functionality completeness. In this PR, the XPU profiler is introduced by following kineto plugin design under libkineto/src/plugin/xpupti. The XPU profiler plugin is built on the foundation of intel PTI toolkit (https://github.com/intel/pti-gpu), and underlying SYCL runtime. The LIBKINETO_NOXPUPTI option is added to enable or disable the XPU profiler plugin during kineto build stage. Signed-off-by: Chen, Zejun <[email protected]>
0f96de9
to
626fa32
Compare
Hi, @aaronenyeshi The XPU profiler is targeting PT 2.5(6th. Sep). We need to land the feature before the timeline. Could you help review? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for creating a subfolder plugin/xpupti for the XPU profiler. I am happy to help merge any diffs into xpupti.
@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@aaronenyeshi merged this pull request in 0cded49. |
Hi, @aaronenyeshi Thank you for help! Really appreciate that! Thank you. |
…130811) As XPU became a PyTorch built-in device, the profiler support is indispensable part of functionality completeness. This PR is associated with the PR to introduce XPU profiler plugin into the kineto. When USE_XPU is enabled, the LIBKINETO_NOXPUPTI option will be suppressed accordingly, which allows kineto to build with XPU profiler plugin. Associated PR to introduce kineto-based XPU profiler into kineto: pytorch/kineto#961 Also updates the Kineto Submodule to include XPU changes. Co-authored-by: Aaron Enye Shi <[email protected]> Pull Request resolved: pytorch#130811 Approved by: https://github.com/aaronenyeshi
Summary: As XPU became a PyTorch built-in device, the profiler support is indispensable part of functionality completeness. In this PR, the XPU profiler is introduced by following kineto plugin design under libkineto/src/plugin/xpupti. The XPU profiler plugin is built on the foundation of intel PTI toolkit (https://github.com/intel/pti-gpu), and underlying SYCL runtime. The LIBKINETO_NOXPUPTI option is added to enable or disable the XPU profiler plugin during kineto build stage. CC: aaronenyeshi briancoutinho davidberard98 sraikund16 Pull Request resolved: pytorch#961 Reviewed By: xuzhao9 Differential Revision: D60830913 Pulled By: aaronenyeshi fbshipit-source-id: a24444e1ab1ed074bfcf5a9012076fa7c193b178
Summary: As XPU became a PyTorch built-in device, the profiler support is indispensable part of functionality completeness. In this PR, the XPU profiler is introduced by following kineto plugin design under libkineto/src/plugin/xpupti. The XPU profiler plugin is built on the foundation of intel PTI toolkit (https://github.com/intel/pti-gpu), and underlying SYCL runtime. The LIBKINETO_NOXPUPTI option is added to enable or disable the XPU profiler plugin during kineto build stage. CC: aaronenyeshi briancoutinho davidberard98 sraikund16 Pull Request resolved: pytorch#961 Reviewed By: xuzhao9 Differential Revision: D60830913 Pulled By: aaronenyeshi fbshipit-source-id: a24444e1ab1ed074bfcf5a9012076fa7c193b178
As XPU became a PyTorch built-in device, the profiler support is indispensable part of functionality completeness. In this PR, the XPU profiler is introduced by following kineto plugin design under libkineto/src/plugin/xpupti. The XPU profiler plugin is built on the foundation of intel PTI toolkit (https://github.com/intel/pti-gpu), and underlying SYCL runtime. The LIBKINETO_NOXPUPTI option is added to enable or disable the XPU profiler plugin during kineto build stage.
CC: @aaronenyeshi @briancoutinho @davidberard98 @sraikund16