Fixed use of designated initializers Windows #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aaronenyeshi
approved these changes
Aug 26, 2024
|
@mantaionut has updated the pull request. You must reimport the pull request before landing. |
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@sraikund16 merged this pull request in 58ed2c0. |
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Fix CUPTI code not compiling on MSVC due to designated initializers not working on Windows. `C:\Work\pytorch\third_party\kineto\libkineto\src\CuptiActivityProfiler.cpp(658): error C7555: use of designated initializers requires at least '/std:c++20'` Pull Request resolved: pytorch#976 Reviewed By: aaronenyeshi Differential Revision: D61810245 Pulled By: sraikund16 fbshipit-source-id: 240a8163477e70b3a3cef0a78bc7cea260d5528e
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Fix CUPTI code not compiling on MSVC due to designated initializers not working on Windows. `C:\Work\pytorch\third_party\kineto\libkineto\src\CuptiActivityProfiler.cpp(658): error C7555: use of designated initializers requires at least '/std:c++20'` Pull Request resolved: pytorch#976 Reviewed By: aaronenyeshi Differential Revision: D61810245 Pulled By: sraikund16 fbshipit-source-id: 240a8163477e70b3a3cef0a78bc7cea260d5528e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CUPTI code not compiling on MSVC due to designated initializers not working on Windows.
C:\Work\pytorch\third_party\kineto\libkineto\src\CuptiActivityProfiler.cpp(658): error C7555: use of designated initializers requires at least '/std:c++20'