Remove libkineto_ci.yml #980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since we already cover building libkineto static library and shared library in libkineto_cuda.yml (which has CUPTI installed), we don't need this CI test anymore. This CI build has been broken and not required. Differential Revision: D61612169 Pulled By: aaronenyeshi
|
This pull request was exported from Phabricator. Differential Revision: D61612169 |
xuzhao9
approved these changes
Aug 22, 2024
|
@aaronenyeshi merged this pull request in ba989ce. |
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#980 Since we already cover building libkineto static library and shared library in libkineto_cuda.yml (which has CUPTI installed), we don't need this CI build anymore. This CI build has been broken for awhile and not required. Test Plan: N/A Reviewed By: sraikund16 Differential Revision: D61612169 Pulled By: aaronenyeshi fbshipit-source-id: 3c6d0974aa757b7f4120227cbd2becfc81fa6ca2
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#980 Since we already cover building libkineto static library and shared library in libkineto_cuda.yml (which has CUPTI installed), we don't need this CI build anymore. This CI build has been broken for awhile and not required. Test Plan: N/A Reviewed By: sraikund16 Differential Revision: D61612169 Pulled By: aaronenyeshi fbshipit-source-id: 3c6d0974aa757b7f4120227cbd2becfc81fa6ca2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since we already cover building libkineto static library and shared library in libkineto_cuda.yml (which has CUPTI installed), we don't need this CI test anymore.
This CI build has been broken and not required.
Differential Revision: D61612169
Pulled By: aaronenyeshi