Enable -Wheader-hygiene for kineto/PACKAGE +1
#981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56539017
|
This pull request was exported from Phabricator. Differential Revision: D56539017 |
|
This pull request has been merged in 464bccf. |
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#981 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56539017 fbshipit-source-id: 79940cb7874dca56e07726f3171bc177afa81d56
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: Pull Request resolved: pytorch#981 Per title #buildmore - Be thorough #buildsonlynotests - No runtime effects! - If you approve of this diff, please use the "Accept & Ship" button no-ig-test - Doesn't require Instagram testing. (1 file modified.) Reviewed By: dmm-fb Differential Revision: D56539017 fbshipit-source-id: 79940cb7874dca56e07726f3171bc177afa81d56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Per title
#buildmore - Be thorough
#buildsonlynotests - No runtime effects!
no-ig-test - Doesn't require Instagram testing.
(1 file modified.)
Reviewed By: dmm-fb
Differential Revision: D56539017