Add Grid/Block To AMD Kernel Profiles #983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D61743013 |
|
This pull request was exported from Phabricator. Differential Revision: D61743013 |
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
Aug 29, 2024
Summary: Pull Request resolved: pytorch#983 Roctracer does not give the grid/block alongside device activities; however, they do have the information in the launch event. Using the correlation we can then stitch these properties using a map from correlation to grid or block. Currently this won't work for RCCL events until ROCm/roctracer#100 is resolved Reviewed By: leitian, aaronenyeshi Differential Revision: D61743013
sraikund16
force-pushed
the
export-D61743013
branch
from
d2e02c9 to
8f287b1
Compare
Summary: Pull Request resolved: pytorch#983 Roctracer does not give the grid/block alongside device activities; however, they do have the information in the launch event. Using the correlation we can then stitch these properties using a map from correlation to grid or block. Currently this won't work for RCCL events until ROCm/roctracer#100 is resolved Reviewed By: leitian, aaronenyeshi Differential Revision: D61743013
sraikund16
force-pushed
the
export-D61743013
branch
from
8f287b1 to
a53c880
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61743013 |
aaronenyeshi
approved these changes
Aug 30, 2024
|
This pull request has been merged in 76f2334. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Roctracer does not give the grid/block alongside device activities; however, they do have the information in the launch event. Using the correlation we can then stitch these properties using a map from correlation to grid or block. Currently this won't work for RCCL events until ROCm/roctracer#100 is resolved
Differential Revision: D61743013