Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call getenv in side threads #984

Closed
wants to merge 6 commits into from
Closed

Don't call getenv in side threads #984

wants to merge 6 commits into from

Conversation

eqy
Copy link
Contributor

@eqy eqy commented Aug 31, 2024 •
edited by malfet
Loading

Calling getenv on side threads is dangerous as it can potentially segfault if the main thread is in the middle of setting environment variables: pytorch/pytorch#134596

This PR only calls getenv only once during the first call of isDaemonEnvVarSet(), which is called from init.

Co-authored-by: Nikita Shulga [email protected]

@eqy eqy changed the title Don't call getenv on side threads Don't call getenv in side threads Aug 31, 2024
nWEIdia
nWEIdia approved these changes Aug 31, 2024
View reviewed changes
Copy link

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genius PR!

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@eqy eqy mentioned this pull request Sep 15, 2024
Closed
malfet
malfet reviewed Oct 1, 2024
View reviewed changes
libkineto/include/Config.h Outdated Show resolved Hide resolved
libkineto/src/Config.cpp Outdated Show resolved Hide resolved
libkineto/src/init.cpp Outdated Show resolved Hide resolved
libkineto/src/init.cpp Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@eqy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@eqy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

malfet
malfet reviewed Oct 1, 2024
View reviewed changes
libkineto/include/Config.h Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@eqy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

sraikund16
sraikund16 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sraikund16 sraikund16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

malfet
malfet reviewed Oct 1, 2024
View reviewed changes
libkineto/src/Config.cpp Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@eqy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

malfet
malfet reviewed Oct 2, 2024
View reviewed changes
libkineto/src/init.cpp Outdated Show resolved Hide resolved
libkineto/src/Config.cpp Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@eqy has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 86f1deb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

@sraikund16 sraikund16 sraikund16 approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eqy @facebook-github-bot @malfet @aaronenyeshi @sraikund16 @nWEIdia