Add CUPTI/RoCM versions to traces #985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62538511 |
aaronenyeshi
approved these changes
Sep 12, 2024
| void addMetadata(const std::string& key, const std::string& value) { | ||
| std::lock_guard<std::mutex> guard(mutex_); | ||
| void addMetadata(const std::string& key, const std::string& value, bool lock_mutex=true) { | ||
| if (lock_mutex){ |
There was a problem hiding this comment.
I'm not certain about the branching logic with mutex controls. I think it can lead to over-complicated scenarios of lock ownership.
Would it make sense to use a recursive_mutex, so that we allow C++ to handle the ownership, and double-locking on the same lock is fine?
There was a problem hiding this comment.
Good point for sure. Let me try a recursive mutex!
Summary: Pull Request resolved: pytorch#985 Because of the differences that are emerging between different versions, it would be useful in the metadata we could see which third-party library version we are using. We add them to our kineto traces in this diff. Reviewed By: aaronenyeshi Differential Revision: D62538511
|
This pull request was exported from Phabricator. Differential Revision: D62538511 |
sraikund16
force-pushed
the
export-D62538511
branch
from
b7f637b to
2bceb21
Compare
|
This pull request has been merged in ca1eedb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Because of the differences that are emerging between different versions, it would be useful in the metadata we could see which third-party library version we are using. We add them to our kineto traces in this diff.
Differential Revision: D62538511