Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roctracer events show up out of order #990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Roctracer events show up out of order #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libkineto/src/RoctracerLogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,8 @@ void RoctracerLogger::activity_callback(const char* begin, const char* end, void
std::unique_lock<std::mutex> lock(s_flush.mutex_);
const roctracer_record_t* record = (const roctracer_record_t*)(begin);
const roctracer_record_t* end_record = (const roctracer_record_t*)(end);

static uint64_t last_end = 0;
static std::string last_kernel_name = "";
while (record < end_record) {
if (record->correlation_id > s_flush.maxCompletedCorrelationId_) {
s_flush.maxCompletedCorrelationId_ = record->correlation_id;
Expand All @@ -320,6 +321,11 @@ void RoctracerLogger::activity_callback(const char* begin, const char* end, void
? demangle(record->kernel_name)
: std::string()
);
if (record->begin_ns < last_end && !row->kernelName.empty() && !last_kernel_name.empty()) {
LOG(WARNING) << "Out of order activity: " << record->begin_ns << " < " << last_end << ". Difference: " << (last_end - record->begin_ns) << " ns. Kernel: " << row->kernelName << " last Kernel: " << last_kernel_name;
}
last_end = record->end_ns;
last_kernel_name = row->kernelName;
insert_row_to_buffer(row);
roctracer_next_record(record, &record);
}
Expand Down
Loading