Align Roctracer to TSC Clock #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62984793 |
Summary: Pull Request resolved: pytorch#991 Right now we align Roctracer events to system clock blindly regardless of what we are using in torch.profiler. We should use a clock based on what is defined instead. This wont fix overlapping kernel events since we do a static offset when aligning but it will help make sure that kernel events always happen after kernel launches Reviewed By: aaronenyeshi, briancoutinho Differential Revision: D62984793
|
This pull request was exported from Phabricator. Differential Revision: D62984793 |
sraikund16
force-pushed
the
export-D62984793
branch
from
8c52a0b to
284f254
Compare
aaronenyeshi
approved these changes
Sep 23, 2024
|
This pull request has been merged in 0a8763e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Right now we align Roctracer events to system clock blindly regardless of what we are using in torch.profiler. We should use a clock based on what is defined instead. This wont fix overlapping kernel events since we do a static offset when aligning but it will help make sure that kernel events always happen after kernel launches
Reviewed By: aaronenyeshi, briancoutinho
Differential Revision: D62984793