Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1ns buffer to Roctracer Events #992

Closed
wants to merge 1 commit into from
Closed

Add 1ns buffer to Roctracer Events #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libkineto/src/RoctracerActivity.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ struct GpuActivity : public RoctracerActivity<roctracerAsyncRow> {
void log(ActivityLogger& logger) const override;
const std::string metadataJson() const override;

// Add small buffer to fix visual error created by https://github.com/ROCm/roctracer/issues/105
// Once this is resolved we can use ifdef to handle having this buffer or not based on version
int64_t timestamp() const override {
return activity_.begin + 1;
}
int64_t duration() const override {
return activity_.end - (activity_.begin + 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be -2 , so that it finishes right before? Or is it okay if end time == parent end time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are only shaving off a nanosecond off the beginning since this is on the gpu track only so there won't be any parent/child minus the annotations which isn't a big deal since we set those ourselves.

}

private:
ActivityType type_;
};
Expand Down
Loading