Skip to content

[Profiling] Upload vLLM Profiling results to AWS S3 - #81

Merged
namanlalitnyu merged 6 commits into
mainfrom
upload-profilers-s3
Sep 17, 2025
Merged

[Profiling] Upload vLLM Profiling results to AWS S3#81
namanlalitnyu merged 6 commits into
mainfrom
upload-profilers-s3

Conversation

@namanlalitnyu

@namanlalitnyu namanlalitnyu commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

This PR includes the following changes:

  • Added a new Github step to upload the vllm profiling results to AWS S3 bucket.
  • Refactoring the way results will be uploaded to S3. We are adding an extra folder name (model_name) to the base S3 prefix, so that it can be easy for us to identify the different profiling results of different models.
  • The S3 path prefix is as follows: <date>/<repository>/<commit_sha>/<github_workflow_id>/<github_job_id>

Testing
Screenshot 2025-09-16 at 11 23 55 PM

Github Action: link

Download link for Profiling traces:

@meta-cla meta-cla Bot added the cla signed label Sep 16, 2025
@namanlalitnyu
namanlalitnyu marked this pull request as ready for review September 16, 2025 20:40
@namanlalitnyu namanlalitnyu changed the title [Profiling] Upload vLLM Profiling results to AWS 3 [Profiling] Upload vLLM Profiling results to AWS S3 Sep 16, 2025
Comment thread .github/scripts/run_vllm_profiling.sh
@linzebing

Copy link
Copy Markdown

Can you share the S3 folder link?

@namanlalitnyu

Copy link
Copy Markdown
Contributor Author

Can you share the S3 folder link?
Hi @linzebing , I actually don't have access to the AWS Console where we can see this results. But, I just verified them from the Github action part since we are using the public github library to upload results.
I just know about the S3 prefix where we can find it: vllm-project/vllm/2025-09-16/218454b9b26cd2185cdf84e3ec9f58538185d06b.

@huydhn Can you please share on how can we double check if its good for us, or in future as well, if we are allowed to visit the AWS console.

@linzebing

linzebing commented Sep 16, 2025

Copy link
Copy Markdown

Can you share the S3 folder link?
Hi @linzebing , I actually don't have access to the AWS Console where we can see this results. But, I just verified them from the Github action part since we are using the public github library to upload results.
I just know about the S3 prefix where we can find it: vllm-project/vllm/2025-09-16/218454b9b26cd2185cdf84e3ec9f58538185d06b.

@huydhn Can you please share on how can we double check if its good for us, or in future as well, if we are allowed to visit the AWS console.

I don't think public S3 folders need any console login. However, I'll defer to @huydhn on the access control level here.

Comment thread .github/workflows/vllm-profiling.yml Outdated
Comment thread .github/workflows/vllm-profiling.yml
Comment thread .github/workflows/vllm-profiling.yml
@huydhn

huydhn commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

I don't think public S3 folders need any console login. However, I'll defer to @huydhn on the access control level here.

All artifacts we have on PyTorch OSS CI is public by default. They can be found on https://gha-artifacts.s3.us-east-1.amazonaws.com/<S3_PREFIX>/<ANY_UPLOADED_FILE>. Let's just keep them public

@namanlalitnyu

Copy link
Copy Markdown
Contributor Author

I don't think public S3 folders need any console login. However, I'll defer to @huydhn on the access control level here.

All artifacts we have on PyTorch OSS CI is public by default. They can be found on https://gha-artifacts.s3.us-east-1.amazonaws.com/<S3_PREFIX>/<ANY_UPLOADED_FILE>. Let's just keep them public

This is awesome, thank you.

@namanlalitnyu
namanlalitnyu merged commit d67c812 into main Sep 17, 2025
3 checks passed
@linzebing

Copy link
Copy Markdown

I have a question: how can I get a directory view of all the traces available for the past 6 months?

@namanlalitnyu

Copy link
Copy Markdown
Contributor Author

I have a question: how can I get a directory view of all the traces available for the past 6 months?

I think there are a couple of ways by which we can see the traces from a directory:

  1. Getting access to the AWS console and seeing from there directly (but not every user can do it).
  2. We can use a python library (eg: boto3), and use it to query S3 path to fetch all the traces present inside that, and render somewhere. (I have implemented this somewhere else, but not in meta).
  3. But, I think yeah, with these urls that generate from these github actions, we just get specific file downloadable links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants