Skip to content

[BugFix] Fixed ParallelEnv + aSyncDataCollector / MultiSyncDataCollector not working if replay_buffer is given#3341

Merged
vmoens merged 8 commits into
pytorch:mainfrom
ParamThakkar123:fix/replay_buffer
Jan 19, 2026
Merged

[BugFix] Fixed ParallelEnv + aSyncDataCollector / MultiSyncDataCollector not working if replay_buffer is given#3341
vmoens merged 8 commits into
pytorch:mainfrom
ParamThakkar123:fix/replay_buffer

Conversation

@ParamThakkar123

Copy link
Copy Markdown
Contributor

Description

Describe your changes in detail.

I changed the inner-collector instantiation so the outer collector's extend_buffer flag is forwarded instead of hardcoding False.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

Fixes #3240

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot

pytorch-bot Bot commented Jan 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3341

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 11 Pending, 1 Unrelated Failure

As of commit 1ceaeb6 with merge base 8f487d4 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2026
@vmoens vmoens added the bug Something isn't working label Jan 19, 2026
@vmoens vmoens merged commit a7e4b69 into pytorch:main Jan 19, 2026
102 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ParallelEnv + aSyncDataCollector / MultiSyncDataCollector not working if replay_buffer is given

2 participants