[BugFix] Harden memmap path handling - #1762
Merged
Merged
Conversation
vmoens
marked this pull request as ready for review
August 8, 2026 20:07
Contributor
Author
Good catch! Yep, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subpathresolution.Rationale
Nested collections previously did not use the same filesystem-key handling as tensor leaves. This aligns save and load behavior across both cases while retaining the explicit
robust_key=Falsecompatibility path and existing overwrite workflows.Validation
1760 passed, 54 skippedacross memmap-focused constructor, TensorDict, and round-trip tests