[Deprecation] Deprecate TensorDictModule.device - #1769
Closed
vmoens wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
github-actions
Bot
added
Deprecation
7 tasks
vmoens
marked this pull request as ready for review
August 21, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates
TensorDictModule.devicein TensorDict 0.15 and schedules its removal for TensorDict 0.17. A module may contain parameters and buffers on multiple devices, so a single inferred device is not a valid module-level property.The property retains its existing behavior during the deprecation window and emits a
DeprecationWarningwith the removal version. The generated API documentation also marks it as deprecated. No replacement scalar-device API is introduced.This PR is stacked on #1767 and should merge after it. Once #1767 lands, this branch can be rebased onto
main.Test plan
python -m pytest test/nn/test_nn.py -k "repr or device_deprecation" -qpython -m pytest test/nn -q(610 passed, 1 skipped)git diff --check