[BugFix] Fix DataLoader batching for ragged lazy stacks - #1772
Open
gtnv wants to merge 1 commit into
Open
Conversation
vmoens
approved these changes
Aug 25, 2026
vmoens
left a comment
Collaborator
There was a problem hiding this comment.
Please remove DataLoader references from the entire PR artifact.
It appears in the title, body/reproduction, branch name, commit subject, and [new test](
tensordict/test/tensordict/test_lazy.py
Lines 278 to 288 in 6cc46a5
__getitems__ directly. Suggested title: [BugFix] Preserve ragged lazy stacks during batched indexing.
The implementation itself is correct so I am approving it but there should not be cross-reference between rl and td in PR/issues unless it provides some context and helps discovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
DataLoaderbatches map datasets through__getitems__.LazyStackedTensorDictinheritedTensorDictBase.__getitems__, so batching bypassed its own indexing logic and tried to stack unequal tensors.Point
__getitems__at the existing lazy-stack__getitem__, keeping ragged batches lazy.Fixes #1296.
Reproduction
On main, DataLoader raises while stacking the unequal tensors. With this change, all assertions pass.