Commit 2447c8b
authored
[torchci] Bump prettier 2.6.2 -> 2.8.8 to support satisfies (fixes yarn format CI) (#8274)
## Problem
The `Run yarn format` CI step (`yarn prettier --write .`) fails on
**every**
torchci PR — including
[#8220](#8220),
which doesn't touch the affected files:
```
[error] components/job/AdvisorSection.tsx: SyntaxError: ',' expected. (15:3)
} satisfies Record<AdvisorVerdictType, { border: string; badge: string }>;
[error] components/job/AiAdvisorIndicator.tsx: SyntaxError: ',' expected. (79:3)
error Command failed with exit code 2.
```
`torchci` pins **`prettier@2.6.2`**, which predates TypeScript
**`satisfies`**
support (added in prettier **2.8.0**). Three files on `main` use
`satisfies`
(`components/job/AdvisorSection.tsx`,
`components/job/AiAdvisorIndicator.tsx`,
`components/autorevert/AutorevertCell.tsx`), so `prettier --write .`
can't parse
them and exits non-zero — failing the format step under `set -e` before
the
diff check. This is pre-existing `main` breakage, not caused by the PRs
that hit it.
## Fix
Bump `prettier` `2.6.2 → 2.8.8` (last 2.x — adds `satisfies` support
with a
minimal formatting delta vs a 3.x major).
## Impact
- `prettier --check .` now passes ("All matched files use Prettier code
style!").
- Formatting churn is just **2 pre-existing files**, 1 line each, where
2.8
parenthesizes indexed-access-on-`typeof` (`typeof X[K]` → `(typeof
X)[K]`).
- `yarn.lock` change is limited to the `prettier` entry (no mass
re-resolution).
## Test plan
- `yarn prettier --write .` → exit 0, no `satisfies` parse errors.
- `yarn prettier --check .` → clean.
AI assistance (Claude) was used for this change.
Signed-off-by: Andrey Talman <atalman@users.noreply.github.com>
Co-authored-by: Andrey Talman <atalman@users.noreply.github.com>1 parent 2dc447a commit 2447c8b
4 files changed
Lines changed: 7 additions & 7 deletions
File tree
- torchci
- components
- benchmark_v3/configs
- testStats
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7857 | 7857 | | |
7858 | 7858 | | |
7859 | 7859 | | |
7860 | | - | |
7861 | | - | |
7862 | | - | |
7863 | | - | |
| 7860 | + | |
| 7861 | + | |
| 7862 | + | |
| 7863 | + | |
7864 | 7864 | | |
7865 | 7865 | | |
7866 | 7866 | | |
| |||
0 commit comments