Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override node20 compatible glibc for linux x86_64 #5959

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Override node20 compatible glibc for linux x86_64 #5959

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3a892c
test
atalman Nov 21, 2024
2dc14f7
test
atalman Nov 21, 2024
38e65cd
test
atalman Nov 21, 2024
34a8908
test
atalman Nov 21, 2024
1015bb0
test
atalman Nov 21, 2024
0a5265c
fix
atalman Nov 21, 2024
a327a8e
test
atalman Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/build_wheels_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@
container:
image: ${{ matrix.container_image }}
options: ${{ matrix.gpu_arch_type == 'cuda' && '--gpus all' || ' ' }}
volumes:
- /node20217:/node20217:rw,rshared
- /node20217:/__e/node20:ro,rshared
timeout-minutes: ${{ inputs.timeout }}
steps:
- name: Clean workspace
Expand All @@ -144,8 +147,17 @@
fi
echo "::endgroup::"

- uses: atalman/checkout-action@main
- name: install nodejs20glibc2.17
if: ${{ inputs.architecture == "x86_64" }}
Fixed Show fixed Hide fixed
run: |
yum install curl -yyq
curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, let's host this on our S3 bucket as I'm not sure how reliably this host is, we might end up ddos it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actions/runner#2906 (comment) says that rehosting the file is not what nodejs allows people to do, so it's better to just stick with this link then

tar -xf node-v20.9.0-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
ldd /__e/node20/bin/node

- uses: actions/checkout@v4
with:
# Support the use case where we need to checkout someone's fork
repository: ${{ inputs.test-infra-repository }}
ref: ${{ inputs.test-infra-ref }}
path: test-infra
Expand Down Expand Up @@ -202,7 +214,7 @@
run: |
{
echo "set +u"
echo "source /opt/intel/oneapi/compiler/latest/env/vars.sh"
echo "source /opt/intel/oneapi/pytorch-gpu-dev-0.5/oneapi-vars.sh"
echo "source /opt/intel/oneapi/pti/latest/env/vars.sh"
} >> "${BUILD_ENV_FILE}"
- name: Install torch dependency
Expand Down
Loading