-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaleup healing #6018
base: main
Are you sure you want to change the base?
scaleup healing #6018
Changes from all commits
e68beca
6bf6896
897c1cf
ef7ee1e
bd84524
818bf44
a4c6f8c
f27e0cf
fee54b5
04b74b3
31bd2cd
27793d0
d5497ac
0d532e9
e422053
b437c42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
all: tflint | ||
|
||
@PHONY: tflint | ||
tflint: tflint-download-lambda tflint-runner-binaries-syncer tflint-runners-instances tflint-runners tflint-setup-iam-permissions tflint-webhook tflint-main | ||
|
||
@PHONY: tflint-download-lambda | ||
tflint-download-lambda: | ||
cd modules/download-lambda && \ | ||
tofu init && \ | ||
tflint --init && \ | ||
tflint --call-module-type=all && \ | ||
tofu validate | ||
|
||
@PHONY: tflint-runner-binaries-syncer | ||
tflint-runner-binaries-syncer: | ||
cd modules/runner-binaries-syncer && \ | ||
tofu init && \ | ||
tflint --init && \ | ||
tflint --call-module-type=all && \ | ||
tofu validate | ||
|
||
@PHONY: tflint-runners-instances | ||
tflint-runners-instances: | ||
cd modules/runners-instances && \ | ||
tofu init && \ | ||
tflint --init && \ | ||
tflint --call-module-type=all && \ | ||
tofu validate | ||
|
||
@PHONY: tflint-runners | ||
tflint-runners: | ||
cd modules/runners && \ | ||
tofu init && \ | ||
tflint --init && \ | ||
tflint --call-module-type=all && \ | ||
tofu validate | ||
|
||
@PHONY: tflint-setup-iam-permissions | ||
tflint-setup-iam-permissions: | ||
cd modules/setup-iam-permissions && \ | ||
tofu init && \ | ||
tflint --init && \ | ||
tflint --call-module-type=all && \ | ||
tofu validate | ||
|
||
@PHONY: tflint-webhook | ||
tflint-webhook: | ||
cd modules/webhook && \ | ||
tofu init && \ | ||
tflint --init && \ | ||
tflint --call-module-type=all && \ | ||
tofu validate | ||
|
||
@PHONY: tflint-main | ||
tflint-main: | ||
tofu init | ||
tflint --init | ||
tflint --call-module-type=all --recursive | ||
tofu validate | ||
|
||
clean: | ||
rm -rf .terraform terraform.lock.hcl |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,8 +36,11 @@ export class Config { | |
readonly retryScaleUpRecordQueueUrl: string | undefined; | ||
readonly runnerGroupName: string | undefined; | ||
readonly runnersExtraLabels: undefined | string; | ||
readonly scaleConfigOrg: string; | ||
readonly scaleConfigRepo: string; | ||
readonly scaleConfigRepoPath: string; | ||
readonly scaleUpMinQueueTimeMinutes: number; | ||
readonly scaleUpRecordQueueUrl: string | undefined; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is this variable doing? I could not find any use in your code except fail if it is not set.... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ZainRizvi could you answer this? I'm also not sure There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I altered it. to be the constant for the URL which is what I thought it was meant to be? But lmk if not |
||
readonly secretsManagerSecretsId: string | undefined; | ||
readonly sSMParamCleanupAgeDays: number; | ||
readonly sSMParamMaxCleanupAllowance: number; | ||
|
@@ -94,8 +97,11 @@ export class Config { | |
/* istanbul ignore next */ | ||
this.retryScaleUpRecordJitterPct = Number(process.env.RETRY_SCALE_UP_RECORD_JITTER_PCT || '0'); | ||
this.retryScaleUpRecordQueueUrl = process.env.RETRY_SCALE_UP_RECORD_QUEUE_URL; | ||
this.scaleUpRecordQueueUrl = process.env.SCALE_UP_RECORD_QUEUE_URL; | ||
this.scaleUpMinQueueTimeMinutes = process.env.SCALE_UP_MIN_QUEUE_TIME_MINUTES ? Number(process.env.SCALE_UP_MIN_QUEUE_TIME_MINUTES) : 30 | ||
this.runnerGroupName = process.env.RUNNER_GROUP_NAME; | ||
this.runnersExtraLabels = process.env.RUNNER_EXTRA_LABELS; | ||
this.scaleConfigOrg = process.env.SCALE_CONFIG_ORG || ''; | ||
/* istanbul ignore next */ | ||
this.scaleConfigRepo = process.env.SCALE_CONFIG_REPO || ''; | ||
if (this.enableOrganizationRunners && !this.scaleConfigRepo) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to test this as well, but here tests can be more relaxed