Improve master_commit_red query performance #6174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
huydhn
reviewed
Jan 17, 2025
| workflow_job job FINAL | ||
| JOIN workflow_run FINAL ON workflow_run.id = workflow_job.run_id | ||
| JOIN push FINAL ON workflow_run.head_commit.'id' = push.head_commit.'id' | ||
| default.workflow_job job final join all_runs workflow_run on workflow_run.id = workflow_job.run_id |
There was a problem hiding this comment.
This reads a bit confusing IMO. If I read it correctly, the all_runs table has the alias as workflow_run, which has the correct syntax. But I always think of workflow_run as the workflow_run table instead of having it as an alias. So, it feels easier just to call it all_runs
huydhn
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
We can only see the improvement on https://hud.pytorch.org/query_execution_metrics after this lands. I wonder if there is a way to get the information for the new query at PR time. Let's chat more on this when you're back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre filter the commits so we can filter the workflow job and workflow run tables on it later
This improves speed for all time ranges up to 1 year. I did not check beyond that
I believe the memory used is about the same, but it scans more rows for some reason
This is the query behind this chart
on the metrics page