Camyllh clickhouse linter #6187
Draft
+240
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
Camyll
commented
Jan 17, 2025
| ) | ||
|
|
||
| #trying this here since having issues with init_command' | ||
| run_command( |
There was a problem hiding this comment.
Issue is here. I know this command should be in the toml file in init_command but I'm getting various errors when I try and run it in there
Camyll
force-pushed
the
camyllh_clickhouse_linter
branch
from
21d1241 to
1283197
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
huydhn
reviewed
Jan 18, 2025
| ) | ||
| ] | ||
|
|
||
| replacement = proc.stdout |
There was a problem hiding this comment.
Oh, this should be proc.stdout.decode("utf-8") I think as it is used to compare with the original string in the next line
huydhn
reviewed
Jan 18, 2025
| original = f.read() | ||
|
|
||
| try: | ||
| proc = run_command( |
There was a problem hiding this comment.
This command removes the comments from the query. Let me check https://github.com/ClickHouse/ClickHouse for more details. The doc says there is --comments to keep the comments but it doesn't seem to work for me https://clickhouse.com/docs/en/operations/utilities/clickhouse-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still in test - creating PR for debugging