Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CI] Add SHA256 checksum for binary uploads to S3" #6212

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jan 23, 2025

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Jan 23, 2025 3:10pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
Copy link

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems bad?

@atalman atalman merged commit db284c6 into main Jan 23, 2025
7 of 31 checks passed
@atalman atalman deleted the revert-6172-ci/upload-object-checksum branch January 23, 2025 15:31
@vit-zikmund
Copy link

Hi, is there any real reason why there was a checksum mismatch?

@clee2000
Copy link
Contributor

clee2000 commented Feb 4, 2025

Hi, is there any real reason why there was a checksum mismatch?

My guess is multi part uploads. #6241 has more context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants