New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable windows arm64 builds for audio and vision #6352

Open

alinpahontu2912 wants to merge 8 commits into pytorch:main from alinpahontu2912:winarm64_wheels

+402 −0

alinpahontu2912 commented Mar 3, 2025

Add scripts and workflow for enabling windows arm64 builds

alinpahontu2912 and others added 2 commits

February 28, 2025 12:58


          add scripts and workflow for Windows arm64 audio & vision wheels

561e93b


          Merge branch 'pytorch:main' into winarm64_wheels

795975b

vercel bot commented Mar 3, 2025

@alinpahontu2912 is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

facebook-github-bot added the CLA Signed label

alinpahontu2912 added 6 commits

March 3, 2025 11:39


          fix workflow_call


          Merge branch 'winarm64_wheels' of https://github.com/alinpahontu2912/…

001d221

…test-infra into winarm64_wheels


          update runner name

07893bb


          update permissions

c9a8eb5


          update workflow and scripts

127cdc0


          add installation link for nightlytorch

ad2318c

alinpahontu2912 marked this pull request as ready for review

March 12, 2025 18:01

seemethere reviewed

View reviewed changes

Member

seemethere left a comment

Would it be possible to add a testing workflow here to validate that we don't break things whenever we make changes?

Similar to https://github.com/pytorch/test-infra/blob/main/.github/workflows/test_build_wheels_windows_with_cuda.yml

.github/workflows/build_wheels_windows_arm64.yml

+                  inputs:
+                    python_version:
+                      required: false
+                      default: "Python312"

Member

seemethere Mar 25, 2025

Suggested change

      
                    default: "Python312"
          
                    default: "3.12"

github-advanced-security bot found potential problems

View reviewed changes

.github/scripts/winarm64/build_vision.bat

+              call .\.venv\Scripts\activate
+              :: Install dependencies
+              pip install numpy

Check failure

Code scanning / lintrunner

PYPIDEP/unpinned PyPI install Error

This line has unpinned PyPi installs; please pin them to a specific version: e.g. 'thepackage==1.2'

.github/workflows/build_wheels_windows_arm64.yml

+                    repository_name:
+                      required: true
+                      type: string
+                      default: "pytorch/vision"

Check failure

Code scanning / lintrunner

ACTIONLINT/[events] Error

input "repository_name" of workflow_call event has the default value "pytorch/vision", but it is also required. if an input is marked as required, its default value will never be used

.github/workflows/build_wheels_windows_arm64.yml

+                    repository_branch:
+                      required: true
+                      type: string
+                      default: "main"

Check failure

Code scanning / lintrunner

ACTIONLINT/[events] Error

input "repository_branch" of workflow_call event has the default value "main", but it is also required. if an input is marked as required, its default value will never be used

.github/workflows/build_wheels_windows_arm64.yml

+              jobs:
+                build:
+                  runs-on: windows-11-arm64

Check failure

Code scanning / lintrunner

ACTIONLINT/[runner-label] Error

label "windows-11-arm64" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows", "ubuntu-24.04", "macos-13", "macos-m1-stable", "linux.12xlarge", "linux.2xlarge", "linux.large", "linux.4xlarge.nvidia.gpu", "linux.g5.4xlarge.nvidia.gpu", "linux.g5.12xlarge.nvidia.gpu". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

.github/workflows/build_wheels_windows_arm64.yml

+                        cmd //c "$SCRIPTS_DIR\\bootstrap_buildtools.bat"
+                    - name: Call Build Script
+                      shell: bash
+                      run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck] Error

shellcheck reported issue in this script: SC2181:style:10:10: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?

.github/workflows/build_wheels_windows_arm64.yml

+                        cmd //c "$SCRIPTS_DIR\\bootstrap_buildtools.bat"
+                    - name: Call Build Script
+                      shell: bash
+                      run: |

Check failure

Code scanning / lintrunner

ACTIONLINT/[shellcheck] Error

shellcheck reported issue in this script: SC2181:style:19:10: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?

Member

seemethere commented Mar 25, 2025

Also not a huge fan of batch and the fact that 3/5 of these scripts are copy / pasted from the pytorch/pytorch repository. I know this is for the sake of getting this out of the door but I don't necessarily feel comfortable accepting this without a confirmation that we will be getting rid of the batch.

For now this is fine, I'm going to set a reminder for myself in 6 months (September 25, 2025) to check on this and if these aren't updated to something other than batch I'm going to recommend we remove them.

seemethere requested changes

View reviewed changes

Member

seemethere left a comment

Going to take a bit of a harder stance on this and say that we shouldn't add new batch at all here.

I know this is inconvenient but I want to hold a higher bar for these since we should be intentional about when we decide to take things on for maintenance and we're purposefully choosing now to not maintain batch.

Please update this PR to convert the batch to either bash or python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels