Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to 3.25 #6443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CMake to 3.25 #6443

wants to merge 1 commit into from

Conversation

cyyever
Copy link

@cyyever cyyever commented Mar 19, 2025

In preparation for updating PyTorch's CMake version. See pytorch/pytorch#130522

Copy link

vercel bot commented Mar 19, 2025

@cyyever is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
@cyyever
Copy link
Author

cyyever commented Mar 19, 2025

@q10 Can you help review?

@q10
Copy link
Contributor

q10 commented Mar 21, 2025

@cyyever looks good to me, hopefully it can be landed soon

@cyyever
Copy link
Author

cyyever commented Mar 22, 2025

@clee2000 @wdvr Could you have a look?

@cyyever
Copy link
Author

cyyever commented Mar 22, 2025

@q10 I have no permission. Because you are more familiar with the maintainers here, could you push it?

@wdvr
Copy link
Contributor

wdvr commented Mar 22, 2025

Started tests

@cyyever
Copy link
Author

cyyever commented Mar 22, 2025

@wdvr Could we remove py3.8 jobs because they are not required by PyTorch?

Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2025 1:13am

@huydhn
Copy link
Contributor

huydhn commented Mar 22, 2025

I have approveed CI run and the test job is running now https://github.com/pytorch/test-infra/actions/runs/14003548921. Because setup-miniconda is a common GHA that is used in lots of different places, I think we should wait until next Monday to merge this when oncall is around.

Also, someone from Dev Infra would need to run Packer to bake the new Windows AMI to confirm that the change works on Windows.

@cyyever
Copy link
Author

cyyever commented Mar 24, 2025

@huydhn MacOS 12 reached EOL, and its test failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants