Skip to content

[Utilization] Add new time range picker and bunch of reusable UI #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 3, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented May 29, 2025

Overview

  • add time range selection for utilization aggregation
  • add checkbox option to filter metrics
  • add symblink
  • auto update url params when the ContextProvider is updated

Notes

Potentially the UM uis created here would be reused when we setup modularized component for upcoming benchmark ux views

Details

Table: Fetch Data

The table is independent to fetch most params from the parent, ideally each of those component has its own data management, only access necessary central control information. this makes the component modularized, with ofc a cost of multiple query, which is expected and clickhouse expense is ok now.

A clean time range picker

image

A clean checkbox option for GeneralizedMeticsTable

image

Demo

https://torchci-git-utilvisualization-fbopensource.vercel.app/utilization/report

yangw-dev added 3 commits May 28, 2025 18:06
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jun 3, 2025 0:50am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
@yangw-dev yangw-dev requested review from huydhn and clee2000 May 29, 2025 01:45
@yangw-dev yangw-dev marked this pull request as ready for review May 29, 2025 01:46
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments but other than that the UI looks fine

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this out :)

yangw-dev added 2 commits May 30, 2025 15:57
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev merged commit 9e6445d into main Jun 3, 2025
6 checks passed
@yangw-dev yangw-dev deleted the utilVisualization branch June 3, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants