-
Notifications
You must be signed in to change notification settings - Fork 98
[Utilization] Add new time range picker and bunch of reusable UI #6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments but other than that the UI looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this out :)
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Overview
Notes
Potentially the UM uis created here would be reused when we setup modularized component for upcoming benchmark ux views
Details
Table: Fetch Data
The table is independent to fetch most params from the parent, ideally each of those component has its own data management, only access necessary central control information. this makes the component modularized, with ofc a cost of multiple query, which is expected and clickhouse expense is ok now.
A clean time range picker
A clean checkbox option for GeneralizedMeticsTable
Demo
https://torchci-git-utilvisualization-fbopensource.vercel.app/utilization/report