Skip to content

[Lambda: Tracking AWS CE] Generate running data from AWS CE #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 4, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented May 29, 2025

  1. setup the lambda to track aws ce runner duration
  2. set up library for clickhouse client for unit test

Signed-off-by: Yang Wang <[email protected]>
Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2025 7:20pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
yangw-dev added 3 commits May 29, 2025 16:47
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev changed the title add model test1 [MONITORING] [Generate running data from AWS CE] May 30, 2025
@yangw-dev yangw-dev changed the title [MONITORING] [Generate running data from AWS CE] [MONITORING] Generate running data from AWS CE May 30, 2025
@huydhn
Copy link
Contributor

huydhn commented May 30, 2025

@jeanschmidt probably won't be happen see the lambda here. Do we have a guide or code pointer on how to create and manage lambda on Terraform? I guess we could take the new scale-up/down chron lambdas as an example, so maybe @ZainRizvi or @Camyll would know

yangw-dev added 2 commits May 29, 2025 18:11
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
yangw-dev added 2 commits May 29, 2025 18:14
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev
Copy link
Contributor Author

@jeanschmidt probably won't be happen see the lambda here. Do we have a guide or code pointer on how to create and manage lambda on Terraform? I guess we could take the new scale-up/down chron lambdas as an example, so maybe @ZainRizvi or @Camyll would know

this is funny, I created the guidance without seeing this haha.

I think last time I synced with jean, he mentioned he wants to do in most cases, the code base for lambda stays in test-infra, and the resources TF in pytorch-labs/GH. Would be curious if there is an exception, for instance, some sensitive lambda etc.

yangw-dev added 3 commits May 29, 2025 22:57
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev changed the title [MONITORING] Generate running data from AWS CE [Lambda: Tracking AWS CE] Generate running data from AWS CE May 30, 2025
yangw-dev added 6 commits May 29, 2025 23:18
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev requested review from malfet and wdvr May 30, 2025 07:11
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev marked this pull request as ready for review May 30, 2025 08:01
@wdvr
Copy link
Contributor

wdvr commented May 30, 2025

Can we rename everywhere ce to costexplorer? I think something like oss_ci_aws_ce is not super clear (same for the clickhouse table)

yangw-dev added 6 commits May 30, 2025 12:27
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev requested a review from wdvr May 30, 2025 20:00
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev requested a review from wdvr May 30, 2025 21:16
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request: Can we find a better name for AWS CE? It's such an obscure term :). Ideally something that reflects it's purpose and doesn't assume it must be backed by AWS (spitballing: "billable-units"?)

@zxiiro
Copy link
Collaborator

zxiiro commented Jun 2, 2025

Small request: Can we find a better name for AWS CE? It's such an obscure term :). Ideally something that reflects it's purpose and doesn't assume it must be backed by AWS (spitballing: "billable-units"?)

Although the code here literally does track with AWS CE so it is descriptive. As I learn more about FinOps though apparently the industry standard term for this is CUR data (Cost and Usage Reporting).

@yangw-dev
Copy link
Contributor Author

I will rename it to CUR!

@yangw-dev yangw-dev requested a review from ZainRizvi June 2, 2025 17:56
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev force-pushed the instanceMonitioring branch from f400420 to bddc1c7 Compare June 2, 2025 18:13
yangw-dev added 2 commits June 2, 2025 11:15
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
@zxiiro
Copy link
Collaborator

zxiiro commented Jun 2, 2025

I will rename it to CUR!

@yangw-dev I don't know how deep into the rabbit hole you want to get but just in case you're interested. There's a standard specification for this kind of data too. https://focus.finops.org

Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev merged commit b3d1c2e into main Jun 4, 2025
7 checks passed
@yangw-dev yangw-dev deleted the instanceMonitioring branch June 4, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants