Skip to content

[ez][HUD] Disabled tests page: Changes to query params and other small things #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jun 2, 2025

A lot of small changes

  • disabled_test_labels query is only called here and it always sets states: [], so I got rid of the param
  • Added config as input for useClickHouseAPI
  • Use useClickHouseAPI in disabled page - not sure if this is actually better or worse
  • Use encodeParams to get the permalink
  • Set query params for disabled_test_labels to be more restrictive. Previously if you change the label selector or the date selector, the selectors would reload because disabled_test_labels thought it had to requery, but now it doesn't
    • Same for the chart and the state, since state doesn't matter to the chart
  • Move the state selector from above the chart to be above the table of tests since state doesn't matter to the chart (makes it more clear what things affect what to users)
  • Use isLoading to differentiate between no data yet and returned no data
  • Use more stacks for spacing
  • Remove some dead code

Very few visual changes, but for context, the page is https://hud.pytorch.org/disabled and they look like:
New:
image

Old:
image

Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jun 2, 2025 7:14pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2025
@clee2000 clee2000 marked this pull request as ready for review June 2, 2025 19:12
@clee2000 clee2000 changed the title [ez][HUD] A bunch of random things on the disabled page [ez][HUD] Disabled tests page: Changes to query params and many other minor things Jun 2, 2025
@clee2000 clee2000 changed the title [ez][HUD] Disabled tests page: Changes to query params and many other minor things [ez][HUD] Disabled tests page: Changes to query params and many other small things Jun 2, 2025
@clee2000 clee2000 requested a review from a team June 2, 2025 21:32
@clee2000 clee2000 changed the title [ez][HUD] Disabled tests page: Changes to query params and many other small things [ez][HUD] Disabled tests page: Changes to query params and other small things Jun 2, 2025
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000 clee2000 merged commit 53c3f00 into main Jun 3, 2025
6 checks passed
@clee2000 clee2000 deleted the csl/hud_disabled_rand branch June 3, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants